Skip to content

Dev/eglaser clang tidy solo#334

Draft
ethanglaser wants to merge 16 commits into
mainfrom
dev/eglaser-clang-tidy-solo
Draft

Dev/eglaser clang tidy solo#334
ethanglaser wants to merge 16 commits into
mainfrom
dev/eglaser-clang-tidy-solo

Conversation

@ethanglaser
Copy link
Copy Markdown
Member

No description provided.

@rfsaliev
Copy link
Copy Markdown
Member

Thank you @ethanglaser , I will base #328 on this.
There are CodeFactor issue. Should I wait for fixes here before rebase?

@ethanglaser
Copy link
Copy Markdown
Member Author

ethanglaser commented May 22, 2026

Thank you @ethanglaser , I will base #328 on this. There are CodeFactor issue. Should I wait for fixes here before rebase?

@rfsaliev no problem - I think I finally got the clang tidy installed and functioning as intended. Feel free to branch off of this / rebase #328 on here if you want to continue progress. I can also work through the clang-tidy resolutions if you're busy with other stuff.

# version is the cause of the template crash. Pin setuptools <81 because the
# wheel's wrapper imports pkg_resources, which setuptools 81 removed.
# Remove once resolved.
pip install 'setuptools<81' clang-tidy==17.0.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to internet resources, the build error:
/workspace/include/svs/lib/threads/threadpool.h:31:10: error: 'omp.h' file not found [clang-diagnostic-error]
Might be caused by missed clang version of OpenMP development package (e.g. libomp-17-dev).
Please update build files to enable OpenMP for clang-tidy.

@rfsaliev
Copy link
Copy Markdown
Member

rfsaliev commented May 28, 2026

This clang-tidy error:
/workspace/bindings/cpp/src/dynamic_vamana_index.cpp:47:5: warning: constructor does not initialize these fields: impl_ [cppcoreguidelines-pro-type-member-init]
Is the false positive - seems like the clang-tidy version is not able to recognize C++ uniform initialization (curly-braced initialization).

@ethanglaser
Copy link
Copy Markdown
Member Author

Seems like the clang-tidy version is not able to recognize C++ uniform initialization (curly-braced initialization).

Do you know which version would support this? I have it at 17 because that is what Meta mentioned they were using, but can be flexible on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants